fix: release command #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamoteshake
commented
Feb 2, 2023
Comment on lines
+212
to
+217
| IIC::wait_ack(); | ||
| IIC::send_byte(WriteAddr & 0xFF); // Send low address | ||
| IIC::wait_ack(); | ||
| IIC::send_byte(DataToWrite); // Receiving mode | ||
| IIC::wait_ack(); | ||
| IIC::stop(); // Generate a stop condition |
There was a problem hiding this comment.
Ignore these. these were just some indentation I fixed to remove some warnings when building.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been pulling my hair why my S1 Plus wasn't respecting my end code from my slicer. I realized that after each SD card print, it runs the
SD_FINISHED_RELEASECOMMANDwhich for some reason have aG1in it. This just pushes the bed to about the middle since S1 Plus is 300x300. I thought it might be better if the user could do what they want for the end code using their preferred slicer.