Fix warnings and make app only render when visible and non-minimized

src/NewWorldMinimap/MapControl.cs

@@ -1,31 +1,48 @@
-using System;
-using System.Collections.Generic;
-using System.ComponentModel;
-using System.Drawing;
+using System.Drawing;
 using System.Drawing.Drawing2D;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using System.Windows.Forms;
 
 namespace NewWorldMinimap
 {
+    /// <summary>
+    /// Custom picture box for rendering as a circle.
+    /// </summary>
+    /// <seealso cref="PictureBox" />
     public class MapControl : PictureBox
     {
+        /// <summary>
+        /// Gets or sets a value indicating whether the image should be rendered as an ellipse.
+        /// </summary>
         public bool IsCircular { get; set; }
 
+        /// <inheritdoc/>
         protected override void OnPaint(PaintEventArgs e)
         {
             base.OnPaint(e);
-            using (var path = new GraphicsPath())
+
+            if (e is null)
+            {
+                return;
+            }
+
+            if (this.Parent is MapForm mapParent)
             {
+                using var path = new GraphicsPath();
+
                 if (IsCircular)
-                    path.AddEllipse(0, 0, (this.Parent as MapForm).DisplayRectangle.Width, (this.Parent as MapForm).DisplayRectangle.Height - 1);
+                {
+                    path.AddEllipse(0, 0, mapParent.DisplayRectangle.Width, mapParent.DisplayRectangle.Height - 1);
+                }
                 else
+                {
                     path.AddRectangle(new Rectangle(0, 0, Parent.Width, Parent.Height));
+                }
+
                 Region = new Region(path);
                 e.Graphics.SmoothingMode = SmoothingMode.AntiAlias;
-                e.Graphics.DrawRectangle(new Pen(new SolidBrush(this.BackColor), 1), 0, 0, this.Width, this.Height);
+                using Brush brush = new SolidBrush(this.BackColor);
+                using Pen pen = new Pen(brush, 1);
+                e.Graphics.DrawRectangle(pen, 0, 0, this.Width, this.Height);
             }
         }
     }

src/NewWorldMinimap/MapForm.cs

@@ -104,8 +104,10 @@ private void SetupHotkeys()
 
         private void ToggleInteractivity()
         {
-            if (this.Opacity == 0)
+            if (!this.Visible)
+            {
                 return;
+            }
 
             overlayMode = !overlayMode;
             SafeInvoke(() =>
@@ -136,12 +138,11 @@ private void ToggleInteractivity()
                     this.TransparencyKey = BackColor;
                 }
             });
-
         }
 
         private void ToggleVisibility()
         {
-            SafeInvoke(() => this.Opacity = this.Opacity == 1.0 ? 0 : 1.0);
+            SafeInvoke(() => this.Visible = !this.Visible);
         }
 
         private void BuildMenu()
@@ -226,9 +227,9 @@ private void ToggleShape(object sender, EventArgs e)
                 {
                     picture.IsCircular = false;
                 }
+
                 this.TransparencyKey = System.Drawing.Color.Empty;
                 this.TransparencyKey = BackColor;
-
             });
         }
 
@@ -282,27 +283,30 @@ private void UpdateLoop()
             {
                 sw.Restart();
 
-                if (pd.TryGetPosition(ScreenGrabber.TakeScreenshot(currentScreen), out Vector2 pos, this.debugEnabled, out Image<Rgba32> debugImage))
+                if (Visible && WindowState != FormWindowState.Minimized)
                 {
-                    Vector2 posDifference = pos - lastPos;
+                    if (pd.TryGetPosition(ScreenGrabber.TakeScreenshot(currentScreen), out Vector2 pos, this.debugEnabled, out Image<Rgba32> debugImage))
+                    {
+                        Vector2 posDifference = pos - lastPos;
+
+                        if (posDifference != Vector2.Zero)
+                        {
+                            rotationAngle = Math.Atan2(posDifference.X, posDifference.Y);
+                        }
 
-                    if (posDifference != Vector2.Zero)
+                        Redraw(pos, rotationAngle);
+
+                        lastPos = pos;
+                    }
+                    else
                     {
-                        rotationAngle = Math.Atan2(posDifference.X, posDifference.Y);
+                        Console.WriteLine($"{i}: Failure");
                     }
 
-                    Redraw(pos, rotationAngle);
+                    DrawDebugImage(debugImage);
 
-                    lastPos = pos;
+                    i++;
                 }
-                else
-                {
-                    Console.WriteLine($"{i}: Failure");
-                }
-
-                DrawDebugImage(debugImage);
-
-                i++;
 
                 sw.Stop();
                 long elapsed = sw.ElapsedMilliseconds;