Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack webhook after a rebuild #3064

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Slack webhook after a rebuild #3064

merged 1 commit into from
Mar 4, 2025

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Mar 4, 2025

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

logging.info("Message sent to slack")
return True
except requests.exceptions.RequestException as e:
logging.error(f"Error sending message to slack: {e}")

Check warning

Code scanning / pylint

Use lazy % formatting in logging functions. Warning

Use lazy % formatting in logging functions.
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 36.84211% with 12 lines in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (9e2b2dd) to head (2d66cd9).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...rparty-core/counterpartycore/lib/monitors/slack.py 35.29% 11 Missing ⚠️
...unterparty-core/counterpartycore/lib/cli/server.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3064      +/-   ##
===========================================
- Coverage    77.99%   77.93%   -0.07%     
===========================================
  Files          102      103       +1     
  Lines        13508    13527      +19     
===========================================
+ Hits         10536    10542       +6     
- Misses        2972     2985      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ouziel-slama ouziel-slama merged commit d7b9460 into develop Mar 4, 2025
29 of 31 checks passed
@ouziel-slama ouziel-slama deleted the slack branch March 4, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants