Don't use Python ConnectionError #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ouziel-slama
commented
Feb 27, 2025
•
- Double-check the spelling and grammar of all strings, code comments, etc.
- Double-check that all code is deterministic that needs to be
- Add tests to cover any new or revised logic
- Ensure that the test suite passes
- Update the project release notes
- Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| import requests | |||
| from bitcoinutils.keys import PublicKey | |||
| from requests.exceptions import ChunkedEncodingError, ReadTimeout, Timeout | |||
| from requests.exceptions import ChunkedEncodingError, ConnectionError, ReadTimeout, Timeout | |||
Check warning
Code scanning / pylint
Redefining built-in 'ConnectionError'. Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3055 +/- ##
===========================================
- Coverage 78.14% 77.19% -0.96%
===========================================
Files 102 102
Lines 13505 13505
===========================================
- Hits 10554 10425 -129
- Misses 2951 3080 +129 ☔ View full report in Codecov by Sentry. |
adamkrellenstein
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.