Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support All Common Address Types #3052

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Support All Common Address Types #3052

wants to merge 10 commits into from

Conversation

ouziel-slama
Copy link
Contributor

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama self-assigned this Feb 27, 2025
@ouziel-slama ouziel-slama marked this pull request as draft February 27, 2025 16:52
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (2a0da56) to head (f554f61).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...unterparty-core/counterpartycore/lib/cli/server.py 0.00% 3 Missing ⚠️
...erparty-core/counterpartycore/lib/parser/blocks.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3052      +/-   ##
===========================================
- Coverage    78.14%   77.50%   -0.65%     
===========================================
  Files          102      102              
  Lines        13505    13521      +16     
===========================================
- Hits         10554    10479      -75     
- Misses        2951     3042      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -195,7 +195,10 @@
try:
self.run_server()
except Exception as e: # pylint: disable=broad-except
logger.error("Error in server thread: %s", e)
import traceback

Check warning

Code scanning / pylint

Import outside toplevel (traceback). Warning

Import outside toplevel (traceback).
parse_block(
db,
block["block_index"],
block["block_time"],
previous_ledger_hash=previous_ledger_hash,
previous_txlist_hash=previous_txlist_hash,
previous_messages_hash=previous_messages_hash,
previous_migration_hash=previous_migration_hash,

Check warning

Code scanning / pylint

Possibly using variable 'previous_migration_hash' before assignment. Warning

Possibly using variable 'previous_migration_hash' before assignment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants