-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support All Common Address Types #3052
base: develop
Are you sure you want to change the base?
Conversation
ouziel-slama
commented
Feb 27, 2025
- Double-check the spelling and grammar of all strings, code comments, etc.
- Double-check that all code is deterministic that needs to be
- Add tests to cover any new or revised logic
- Ensure that the test suite passes
- Update the project release notes
- Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3052 +/- ##
===========================================
- Coverage 78.14% 77.50% -0.65%
===========================================
Files 102 102
Lines 13505 13521 +16
===========================================
- Hits 10554 10479 -75
- Misses 2951 3042 +91 ☔ View full report in Codecov by Sentry. |
@@ -195,7 +195,10 @@ | |||
try: | |||
self.run_server() | |||
except Exception as e: # pylint: disable=broad-except | |||
logger.error("Error in server thread: %s", e) | |||
import traceback |
Check warning
Code scanning / pylint
Import outside toplevel (traceback). Warning
parse_block( | ||
db, | ||
block["block_index"], | ||
block["block_time"], | ||
previous_ledger_hash=previous_ledger_hash, | ||
previous_txlist_hash=previous_txlist_hash, | ||
previous_messages_hash=previous_messages_hash, | ||
previous_migration_hash=previous_migration_hash, |
Check warning
Code scanning / pylint
Possibly using variable 'previous_migration_hash' before assignment. Warning