Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebuild command #3047

Merged
merged 5 commits into from
Feb 25, 2025
Merged

rebuild command #3047

merged 5 commits into from
Feb 25, 2025

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Feb 25, 2025

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft February 25, 2025 16:17
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (8926635) to head (2e2e1e2).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...unterparty-core/counterpartycore/lib/cli/server.py 77.27% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3047      +/-   ##
===========================================
+ Coverage    77.09%   78.03%   +0.94%     
===========================================
  Files           99       99              
  Lines        13479    13497      +18     
===========================================
+ Hits         10392    10533     +141     
+ Misses        3087     2964     -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ouziel-slama ouziel-slama marked this pull request as ready for review February 25, 2025 17:05
@ouziel-slama ouziel-slama merged commit 336ca63 into develop Feb 25, 2025
31 checks passed
@ouziel-slama ouziel-slama deleted the rebuild branch February 25, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants