Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3028

Merged
merged 11 commits into from
Feb 19, 2025

complete release notes

722bbb6
Select commit
Loading
Failed to load commit list.
Merged

Fixes #3028

complete release notes
722bbb6
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / pylint completed Feb 19, 2025 in 3s

1 configuration not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 1 configuration present on refs/heads/develop was not found:

Actions workflow (pylint.yml)

  • ❓  .github/workflows/pylint.yml:build/python-version:3.11

New alerts in code changed by this pull request

  • 7 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 532 in counterparty-core/counterpartycore/lib/api/apiserver.py

See this annotation in the file changed.

Code scanning / pylint

Consider using 'sys.exit' instead. Warning

Consider using 'sys.exit' instead.

Check warning on line 14 in counterparty-core/counterpartycore/lib/cli/server.py

See this annotation in the file changed.

Code scanning / pylint

Unable to import 'apsw'. Warning

Unable to import 'apsw'.

Check warning on line 644 in counterparty-core/counterpartycore/lib/cli/server.py

See this annotation in the file changed.

Code scanning / pylint

Use lazy % or .format() formatting in logging functions. Warning

Use lazy % or .format() formatting in logging functions.

Check warning on line 644 in counterparty-core/counterpartycore/lib/cli/server.py

See this annotation in the file changed.

Code scanning / pylint

Formatting a regular string which could be an f-string. Warning

Formatting a regular string which could be an f-string.

Check warning on line 662 in counterparty-core/counterpartycore/lib/cli/server.py

See this annotation in the file changed.

Code scanning / pylint

Too many instance attributes (12/7). Warning

Too many instance attributes (12/7).

Check warning on line 678 in counterparty-core/counterpartycore/lib/cli/server.py

See this annotation in the file changed.

Code scanning / pylint

Filter out default values #TODO: these should be set in a different way. Warning

Filter out default values #TODO: these should be set in a different way.

Check warning on line 260 in counterparty-core/counterpartycore/lib/parser/follow.py

See this annotation in the file changed.

Code scanning / pylint

Boolean condition "True and not self.stop_event.is_set()" may be simplified to "not self.stop_event.is_set()". Warning

Boolean condition "True and not self.stop_event.is_set()" may be simplified to "not self.stop_event.is_set()".