Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3023

Merged
merged 6 commits into from
Feb 17, 2025
Merged

Fixes #3023

merged 6 commits into from
Feb 17, 2025

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Feb 17, 2025

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft February 17, 2025 12:52
try:
check_signature(zst_filepath, sig_url)
decompress_zst(zst_filepath)
except Exception as e:

Check warning

Code scanning / pylint

Catching too general exception Exception. Warning

Catching too general exception Exception.
# download .zst file
try:
zst_filepath = download_zst(data_dir, zst_url)
except Exception as e:

Check warning

Code scanning / pylint

Catching too general exception Exception. Warning

Catching too general exception Exception.
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 53.19149% with 22 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (30b7dd7) to head (16b44b2).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
...erparty-core/counterpartycore/lib/cli/bootstrap.py 52.00% 12 Missing ⚠️
...rty-core/counterpartycore/lib/backend/rsfetcher.py 0.00% 5 Missing ⚠️
counterparty-core/counterpartycore/lib/api/wsgi.py 0.00% 2 Missing ⚠️
...arty-core/counterpartycore/lib/backend/bitcoind.py 0.00% 2 Missing ⚠️
...y-core/counterpartycore/lib/ledger/currentstate.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3023      +/-   ##
===========================================
- Coverage    80.77%   80.62%   -0.16%     
===========================================
  Files           99       99              
  Lines        13331    13351      +20     
===========================================
- Hits         10768    10764       -4     
- Misses        2563     2587      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from badges to develop February 17, 2025 13:54
@ouziel-slama ouziel-slama marked this pull request as ready for review February 17, 2025 15:37
@ouziel-slama ouziel-slama merged commit dbc0775 into develop Feb 17, 2025
30 of 32 checks passed
@ouziel-slama ouziel-slama deleted the fixes branch February 17, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants