Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v10.4.2 #2294

Merged
merged 37 commits into from
Oct 3, 2024
Merged

v10.4.2 #2294

merged 37 commits into from
Oct 3, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Oct 2, 2024

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@@ -134,6 +134,10 @@
return rpc("createrawtransaction", [inputs, outputs])


def getrawmempool(verbose=False):
return rpc("getrawmempool", [True if verbose else False])

Check warning

Code scanning / pylint

The if expression can be replaced with 'bool(test)'. Warning

The if expression can be replaced with 'bool(test)'.
logger.debug("Starting Prefetcher...")
try:
self.config["start_height"] = start_height
self.next_height = start_height

Check warning

Code scanning / pylint

Attribute 'next_height' defined outside init. Warning

Attribute 'next_height' defined outside __init__.
@@ -65,6 +57,13 @@
except Exception as e:
logger.error(f"Failed to initialize fetcher: {e}. Retrying in 5 seconds...")
raise e
# prefetching
self.stopped = False

Check warning

Code scanning / pylint

Attribute 'stopped' defined outside init. Warning

Attribute 'stopped' defined outside __init__.
@@ -65,6 +57,13 @@
except Exception as e:
logger.error(f"Failed to initialize fetcher: {e}. Retrying in 5 seconds...")
raise e
# prefetching
self.stopped = False
self.prefetch_queue = {}

Check warning

Code scanning / pylint

Attribute 'prefetch_queue' defined outside init. Warning

Attribute 'prefetch_queue' defined outside __init__.
# prefetching
self.stopped = False
self.prefetch_queue = {}
self.prefetch_queue_size = 0

Check warning

Code scanning / pylint

Attribute 'prefetch_queue_size' defined outside init. Warning

Attribute 'prefetch_queue_size' defined outside __init__.
self.stopped = False
self.prefetch_queue = {}
self.prefetch_queue_size = 0
self.executor = ThreadPoolExecutor(max_workers=WORKER_THREADS)

Check warning

Code scanning / pylint

Attribute 'executor' defined outside init. Warning

Attribute 'executor' defined outside __init__.
self.prefetch_queue_size = 0
self.executor = ThreadPoolExecutor(max_workers=WORKER_THREADS)
self.prefetch_task = self.executor.submit(self.prefetch_blocks)
self.prefetch_queue_initialized = False

Check warning

Code scanning / pylint

Attribute 'prefetch_queue_initialized' defined outside init. Warning

Attribute 'prefetch_queue_initialized' defined outside __init__.
Merge pull request #2257 from CounterpartyXCP/develop
@ouziel-slama ouziel-slama merged commit 9e3cca8 into master Oct 3, 2024
19 checks passed
ouziel-slama added a commit that referenced this pull request Oct 5, 2024
Merge pull request #2294 from CounterpartyXCP/develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants