Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v10.4.0 #2242

Merged
merged 228 commits into from
Sep 18, 2024
Merged

v10.4.0 #2242

merged 228 commits into from
Sep 18, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Sep 18, 2024 •
edited
Loading

https://github.com/CounterpartyXCP/counterparty-core/releases/tag/v10.4.0

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

Ouziel added 30 commits August 8, 2024 09:06
@Ouziel
Dispenser must be created by source
73c397f
@Ouziel
status == STATUS_OPEN_EMPTY_ADDRESS means open_address != source
d34f680
@Ouziel
Don't raise error on closing
249bc95
@Ouziel
Compose dispense
1be848d
@Ouziel
Add some tests
b3620d5
@Ouziel
More tests; remove None from potential dispensers
74c5b0d
@Ouziel
Add 'disable_vanilla_btc_dispense' protocol change
6b299b3
@Ouziel
update blueprint
65ba64d
@Ouziel
compose only if 'enable_dispense_tx' is enabled
5efcff0
@Ouziel
Update release notes
40b3f40
@Ouziel
update release notes
61ab6a3
@Ouziel
update blueprint
9447d1d
@Ouziel
Introduce fairminter.py
e3400f9
@Ouziel
Simplify pack format
ec47956
@Ouziel
Description cannot contain the '|' character.
e9553ce
@Ouziel
clean arguments order
c61a1ff
@Ouziel
disable too-many-arguments and too-many-locals
855034d
@Ouziel
Make dispense transaction more normal
2051bb0
@Ouziel
fix tests
280caf0
@Ouziel
Merge branch 'develop' into composedispense
0abd4c7
@Ouziel
Merge branch 'develop' into requiresource
e92b455
@Ouziel
Merge branch 'develop' into fairminting
0fecf05
@Ouziel
let's add some tests!
46af7b4
@Ouziel
fairminter.py progress
4a7cb00
@Ouziel
open and close fairminters
0fbf16d
@Ouziel
Introduce 'fairmint.py'
c51fe9b
@Ouziel
fairmint.py progress
c6ed2a2
@Ouziel
soft cap management
6c93e6f
@Ouziel
close fairminter when hardcap is reached
6b00eb5
@Ouziel
Add compose functions and endpoints
3e72fdb
Ouziel and others added 23 commits September 16, 2024 10:04
@Ouziel
Reduce Sentry Reporting Rate
4938cb9
@Ouziel
clean debug
5974a62
@Ouziel
trigger docker compose test
7a0b6ca
@Ouziel
more comments
cecb0b0
@Ouziel
set protocol changes activation at block 866000
462a469
@Ouziel
set disable_vanilla_btc_dispense at 866000
cc9b72e
@Ouziel
Add getmempoolinfo endpoint
879167a
@Ouziel
update fixtures
f4f14cc
@ouziel-slama
Merge pull request #2227 from CounterpartyXCP/getmempoolinfo
fc0629d 
Add `getmempoolinfo` endpoint
@Ouziel
Check previous block
23970a5
@ouziel-slama
Merge pull request #2233 from CounterpartyXCP/fixmissblock
49facee 
Check previous block
@Ouziel
Log API v1 responses
463cf16
@Ouziel
update release notes
a120f02
@ouziel-slama
Merge pull request #2236 from CounterpartyXCP/redirecttov1
58d4d56 
Log API v1 responses
@Ouziel
Merge branch 'develop' into preprelease
df171c1
@Ouziel
Fix reparse
7a918d8
@ouziel-slama
Merge pull request #2239 from CounterpartyXCP/testcompose
bf4db54 
Fix reparse
@Ouziel
Use orders cache only on catch up
ffb0242
@Ouziel
update release notes
788240b
@Ouziel
update release notes
99257c7
@ouziel-slama
Merge pull request #2241 from CounterpartyXCP/testcompose
781f56c 
Use order caching only during catch-up
@adamkrellenstein
Release Notes
a1291b2
@ouziel-slama
Merge pull request #2224 from CounterpartyXCP/preprelease
177b640 
Prepare release
@ouziel-slama ouziel-slama changed the title v10.4.1 v10.4.0 Sep 18, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 18, 2024
View reviewed changes
counterparty-core/counterpartycore/lib/blocks.py
@@ -910,7 +973,9 @@
else:
assert block_index == util.CURRENT_BLOCK_INDEX

if source and (data or destination == config.UNSPENDABLE or dispensers_outs):
if (source and (data or destination == config.UNSPENDABLE or dispensers_outs)) or len(

Check warning

Code scanning / pylint

Unnecessary "else" after "return", remove the "else" and de-indent the code inside it. Warning

Unnecessary "else" after "return", remove the "else" and de-indent the code inside it.
counterparty-core/counterpartycore/lib/gas.py
def sigmoid(t):
return 1 / (1 + math.exp(-k * (t - 0.5)))

if x <= a:

Check warning

Code scanning / pylint

Unnecessary "elif" after "return", remove the leading "el" from "elif". Warning

Unnecessary "elif" after "return", remove the leading "el" from "elif".
counterparty-core/counterpartycore/lib/messages/dispense.py
return message


def parse(db, tx):

Check warning

Code scanning / pylint

Too many branches (13/12). Warning

Too many branches (13/12).
counterparty-core/counterpartycore/lib/messages/dispense.py

dispense_index = 0

for next_out in outs:

Check warning

Code scanning / pylint

Too many nested blocks (6/5). Warning

Too many nested blocks (6/5).
counterparty-core/counterpartycore/lib/messages/fairminter.py
)


def validate(

Check warning

Code scanning / pylint

Too many branches (36/12). Warning

Too many branches (36/12).
counterparty-core/counterpartycore/lib/transaction.py
@@ -30,6 +30,7 @@
util,
)
from counterpartycore.lib.backend import addrindexrs
from counterpartycore.lib.messages import dispense # noqa: F401

Check warning

Code scanning / pylint

Unused dispense imported from counterpartycore.lib.messages. Warning

Unused dispense imported from counterpartycore.lib.messages.
counterparty-core/counterpartycore/lib/transaction.py
)


def compose_movetoutxo(db, utxo: str, destination: str, more_utxos: str = ""):

Check warning

Code scanning / pylint

Unused argument 'db'. Warning

Unused argument 'db'.
counterparty-core/counterpartycore/lib/util.py
os.path.dirname(config.DATABASE), "regtest_disabled_changes.json"
)
if os.path.exists(regtest_protocole_file):
with open(regtest_protocole_file) as f:

Check warning

Code scanning / pylint

Using open without explicitly specifying an encoding. Warning

Using open without explicitly specifying an encoding.
counterparty-core/counterpartycore/lib/util.py
os.path.dirname(config.DATABASE), "regtest_disabled_changes.json"
)
if os.path.exists(regtest_protocole_file):
with open(regtest_protocole_file) as f:

Check warning

Code scanning / pylint

Redefining name 'f' from outer scope (line 546). Warning

Redefining name 'f' from outer scope (line 546).
counterparty-core/counterpartycore/lib/util.py
@@ -584,3 +633,22 @@

def ib2h(b):
return inverse_hash(b2h(b))


def is_utxo_format(value):

Check warning

Code scanning / pylint

Too many return statements (7/6). Warning

Too many return statements (7/6).
@ouziel-slama ouziel-slama merged commit 827ae09 into master Sep 18, 2024
19 checks passed
ouziel-slama added a commit that referenced this pull request Sep 24, 2024
@ouziel-slama
Merge pull request #2258 from CounterpartyXCP/master
55d7535 
Merge pull request #2242 from CounterpartyXCP/develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ouziel-slama @adamkrellenstein @Ouziel @warrenpuffett