use vin info from RSFecther in gettxinfo_legacy()

counterparty-core/counterpartycore/lib/backend/bitcoind.py

@@ -540,10 +540,17 @@ def list_unspent(source, allow_unconfirmed_inputs):
 
 
 def get_vin_info(vin, no_retry=False):
-    vin_ctx = get_decoded_transaction(vin["hash"], no_retry=no_retry)
-    is_segwit = vin_ctx["segwit"]
-    vout = vin_ctx["vout"][vin["n"]]
-    return vout["value"], vout["script_pub_key"], is_segwit
+    vin_info = vin.get("info")
+    if vin_info is None:
+        try:
+            vin_ctx = get_decoded_transaction(vin["hash"], no_retry=no_retry)
+            is_segwit = vin_ctx["segwit"]
+            vout = vin_ctx["vout"][vin["n"]]
+            return vout["value"], vout["script_pub_key"], is_segwit
+        except exceptions.BitcoindRPCError as e:
+            raise exceptions.DecodeError("vin not found") from e
+    else:
+        return vin_info["value"], vin_info["script_pub_key"], vin_info["is_segwit"]
 
 
 def get_vins_info(vins, no_retry=False):

counterparty-core/counterpartycore/lib/parser/gettxinfo.py

@@ -226,23 +226,14 @@ def check_signatures_sighash_flag(decoded_tx):
             raise SighashFlagError(error)
 
 
-def get_vin_info(vin):
-    vin_info = vin.get("info")
-    if vin_info is None:
-        try:
-            return backend.bitcoind.get_vin_info(vin, no_retry=CurrentState().parsing_mempool())
-        except exceptions.BitcoindRPCError as e:
-            raise DecodeError("vin not found") from e
-    else:
-        return vin_info["value"], vin_info["script_pub_key"], vin_info["is_segwit"]
-
-
 def get_transaction_sources(decoded_tx):
     sources = []
     outputs_value = 0
 
     for vin in decoded_tx["vin"]:  # Loop through inputs.
-        vout_value, script_pubkey, _is_segwit = get_vin_info(vin)
+        vout_value, script_pubkey, _is_segwit = backend.bitcoind.get_vin_info(
+            vin, no_retry=CurrentState().parsing_mempool()
+        )
 
         outputs_value += vout_value
 
@@ -282,7 +273,9 @@ def get_transaction_source_from_p2sh(decoded_tx, p2sh_is_segwit):
     outputs_value = 0
 
     for vin in decoded_tx["vin"]:
-        vout_value, _script_pubkey, is_segwit = get_vin_info(vin)
+        vout_value, _script_pubkey, is_segwit = backend.bitcoind.get_vin_info(
+            vin, no_retry=CurrentState().parsing_mempool()
+        )
 
         if protocol.enabled("prevout_segwit_fix"):
             prevout_is_segwit = is_segwit

counterparty-core/counterpartycore/lib/parser/gettxinfolegacy.py

@@ -3,7 +3,7 @@
 
 from arc4 import ARC4
 
-from counterpartycore.lib import backend, config, exceptions
+from counterpartycore.lib import backend, config
 from counterpartycore.lib.exceptions import BTCOnlyError, DecodeError
 from counterpartycore.lib.ledger.currentstate import CurrentState
 from counterpartycore.lib.parser import protocol
@@ -146,16 +146,11 @@ def get_tx_info_legacy(decoded_tx, block_index):
         raise BTCOnlyError("no data and not unspendable")
 
     # Collect all possible source addresses; ignore coinbase transactions and anything but the simplest Pay‐to‐PubkeyHash inputs.
-    # get inputs info by batch
-    try:
-        vins_info = backend.bitcoind.get_vins_info(
-            decoded_tx["vin"], no_retry=CurrentState().parsing_mempool()
-        )
-    except exceptions.BitcoindRPCError as e:
-        raise DecodeError("vin not found") from e
-
     source_list = []
-    for vout_value, script_pubkey, _is_segwit in vins_info:  # Loop through input transactions.
+    for vin in decoded_tx["vin"]:  # Loop through input transactions.
+        vout_value, script_pubkey, _is_segwit = backend.bitcoind.get_vin_info(
+            vin, no_retry=CurrentState().parsing_mempool()
+        )
         fee += vout_value
 
         address = get_address(script_pubkey, block_index)