Esas/disable powerbi component prod 13567 #875
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-wave-0f618f503-875.westeurope.azurestaticapps.net |
077e657 to
ec4b4d5
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-wave-0f618f503-875.westeurope.azurestaticapps.net |
ec4b4d5 to
d0cc305
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-wave-0f618f503-875.westeurope.azurestaticapps.net |
src/hooks/RouterHooks.js
Outdated
| isUnmounted.current = true; | ||
| }; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [currentWorkspaceData?.webApp?.options?.charts, navigate]); |
There was a problem hiding this comment.
Is it a good use to manualy disable useEffect warnings ?
public/locales/fr/translation.json
Outdated
| @@ -298,6 +298,7 @@ | |||
| "unknownStatus": { | |||
| "label": "Le scénario a un statut inconnu, si le problème persiste, merci de contacter votre administrateur" | |||
| }, | |||
| "resultsDisplayDisabled": "La simulation a fini avec succès mais l'affichage des résultats est désactivé", | |||
There was a problem hiding this comment.
Maybe "s'est terminée" indeed of "a fini" ?
| }); | ||
|
|
||
| it('can launch a scenario and show Display of results is disabled dashboard', () => { | ||
| cy.get(GENERIC_SELECTORS.dashboards.tabName).should('not.exist'); |
There was a problem hiding this comment.
Maybe a function who should return this cy.get ?
d0cc305 to
cae4345
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-wave-0f618f503-875.westeurope.azurestaticapps.net |
cae4345 to
4034f82
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-wave-0f618f503-875.westeurope.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-wave-0f618f503-875.westeurope.azurestaticapps.net |
…rds config doesn't exist
425d1ea to
ff0ed63
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-wave-0f618f503-875.westeurope.azurestaticapps.net |
Before creating a PR, please check that:
yarn test)