fix: fix webapp crash when parameter list contains a nullish element

- remove nullish elements from arrays when using mergeArraysByElementsIds - mergeArraysByElementsIds no longer modify the input arrays
Cosmo-Tech · Mar 18, 2024 · 4bdc4de · 4bdc4de
1 parent 4f2ec25
commit 4bdc4de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/utils/ArrayDictUtils.js b/src/utils/ArrayDictUtils.js
@@ -9,12 +9,9 @@ const mergeArraysByElementsIds = (array1, array2) => {
   if (array2 == null) return array1;
 
   array2.forEach((el2) => {
-    const indexToPatch = array1.findIndex((el1) => el1.id === el2.id);
-    if (indexToPatch !== -1) {
-      array1[indexToPatch] = merge(array1[indexToPatch], el2);
-    } else {
-      array1.push(el2);
-    }
+    const indexToPatch = array1.findIndex((el1) => el1?.id === el2?.id);
+    if (el2 != null && indexToPatch !== -1) array1[indexToPatch] = merge(array1[indexToPatch], el2);
+    else array1.push(el2);
   });
 
   return array1;

diff --git a/src/utils/__test__/ArrayDictUtils.spec.js b/src/utils/__test__/ArrayDictUtils.spec.js
@@ -7,17 +7,21 @@ describe('mergeArraysByElementsIds', () => {
     { id: 'id1', value: 'value1', nested: { 1: 1, 2: 2 } },
     { id: 'id2', value: 'value2' },
     { id: 'id3', value: 'value3' },
+    null,
   ];
   const overridingArray = [
     { id: 'id1', value: 'newValue1', nested: { 2: 'two', 3: 3 } },
     { id: 'id2', newAttribute: 'attribute2' },
     { id: 'id4', value: 'value4' },
+    undefined,
   ];
   const mergedResult = [
     { id: 'id1', value: 'newValue1', nested: { 1: 1, 2: 'two', 3: 3 } },
     { id: 'id2', value: 'value2', newAttribute: 'attribute2' },
     { id: 'id3', value: 'value3' },
+    null,
     { id: 'id4', value: 'value4' },
+    undefined,
   ];
 
   test.each`