Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unchecked flag #612

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix unchecked flag #612

merged 2 commits into from
Jan 22, 2025

Conversation

chipshort
Copy link
Collaborator

No description provided.

@chipshort chipshort marked this pull request as ready for review January 22, 2025 10:02
webmaster128
webmaster128 reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test which verifies this code path? E.g. store a Wasm with a wrong interface_version_ marker export

webmaster128
webmaster128 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

internal/api/lib_test.go
require.NoError(t, err)
expectedChecksum := sha256.Sum256(wasm)
assert.Equal(t, expectedChecksum[:], checksum)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@chipshort chipshort merged commit 2ad8725 into main Jan 22, 2025
15 checks passed
@chipshort chipshort deleted the co/fix-store-code-unchecked branch January 22, 2025 14:12
@chipshort
Copy link
Collaborator Author

@Mergifyio backport release/2.2

@mergify Mergify
Copy link

mergify bot commented Jan 22, 2025 •
edited
Loading

backport release/2.2

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 22, 2025
Merged
chipshort added a commit that referenced this pull request Jan 22, 2025
@chipshort
Merge pull request #613 from CosmWasm/mergify/bp/release/2.2/pr-612
5e2c684 
Fix unchecked flag (backport #612)
@chipshort
Copy link
Collaborator Author

@Mergifyio backport release/1.5 release/2.0 release/2.1

@mergify Mergify
Copy link

mergify bot commented Jan 22, 2025 •
edited
Loading

backport release/1.5 release/2.0 release/2.1

✅ Backports have been created

This was referenced Jan 22, 2025
Merged
Merged
Merged
chipshort added a commit that referenced this pull request Jan 22, 2025
@chipshort
Merge pull request #616 from CosmWasm/mergify/bp/release/2.1/pr-612
4077814 
Fix unchecked flag (backport #612)
chipshort added a commit that referenced this pull request Jan 22, 2025
@chipshort
Merge pull request #614 from CosmWasm/mergify/bp/release/1.5/pr-612
41fd6d6 
Fix unchecked flag (backport #612)
chipshort added a commit that referenced this pull request Jan 22, 2025
@chipshort
Merge pull request #615 from CosmWasm/mergify/bp/release/2.0/pr-612
2d8c291 
Fix unchecked flag (backport #612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@kulikthebird kulikthebird Awaiting requested review from kulikthebird

@aumetra aumetra Awaiting requested review from aumetra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chipshort @webmaster128