Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6 #42

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Release 0.6 #42

merged 3 commits into from
Jan 16, 2020

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Jan 15, 2020

Closes #32 and #41

Includes cosmwasm 0.6.3

  • Build linux support with CentOS7 and recent Debian and Ubuntu
  • Build osx support with support for 10.7 and newer
  • NO WINDOWS SUPPORT (see Add windows support #28)

@ethanfrey
Copy link
Member Author

I tested this on Ubuntu 18.04.
make test works with these dlls

@clevinson
Copy link

Tested on macOS 10.14, go1.13.6

All tests pass, but i'm getting a Rust thread panic error in the middle of one test. Not sure if this is expected behavior.

go-cosmwasm ; make test
RUST_BACKTRACES=1 go test -v ./api ./types
=== RUN   TestInitAndReleaseCache
--- PASS: TestInitAndReleaseCache (0.00s)
=== RUN   TestCreateAndGet
--- PASS: TestCreateAndGet (0.04s)
=== RUN   TestCreateFailsWithBadData
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: InvalidMagic', /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/cosmwasm-vm-0.6.3/src/compatability.rs:39:19
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
--- PASS: TestCreateFailsWithBadData (0.00s)
=== RUN   TestInstantiate
--- PASS: TestInstantiate (0.04s)
=== RUN   TestHandle
Time (87_433 gas): 4.887782ms
Time (130_070 gas): 266.249µs
--- PASS: TestHandle (0.04s)
=== RUN   TestMultipleInstances
--- PASS: TestMultipleInstances (0.04s)
=== RUN   TestQuery
--- PASS: TestQuery (0.04s)
=== RUN   TestMockApi
--- PASS: TestMockApi (0.00s)
PASS
ok  	github.com/confio/go-cosmwasm/api	(cached)
=== RUN   TestCanoncialAddress
--- PASS: TestCanoncialAddress (0.00s)
PASS
ok  	github.com/confio/go-cosmwasm/types	(cached)

Also, RUST_BACKTRACE=1 does not seem to work when running go test. The Makefile currently has a type-o of RUST_BACKTRACES=1 instead of RUST_BACKTRACE=1, but fixing the type-o still does not give me a full backtrace when running make test.

@ethanfrey
Copy link
Member Author

That is a triggered panic to test that dll catches those and doesn't let them hit the ffi layer, which can crash the app.

Good point on BACKTRACES. They never worked inside a dll... but I can always hope

@ethanfrey ethanfrey merged commit 5c1370f into master Jan 16, 2020
@ethanfrey ethanfrey deleted the release-0.6 branch January 16, 2020 09:07
@ethanfrey ethanfrey mentioned this pull request Jan 16, 2020
tomtau pushed a commit to tomtau/wasmvm that referenced this pull request Oct 6, 2021
faddat pushed a commit to faddat/go-cosmwasm that referenced this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasmd does not run on centos 7
2 participants