Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map::first and Map::last methods #42

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Map::first and Map::last methods #42

merged 3 commits into from
Jun 12, 2023

Conversation

chipshort
Copy link
Collaborator

closes #35

@chipshort chipshort requested a review from webmaster128 June 9, 2023 10:53
@chipshort chipshort changed the base branch from main to release/1.1 June 9, 2023 10:55
@chipshort
Copy link
Collaborator Author

Looks like the coverage check is not happy with doc-tests

ueco-jb
ueco-jb approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

webmaster128
webmaster128 reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write some unit tests too (maybe just copy the docs links)? Then unit tests and docs can evolve independently.

@chipshort chipshort force-pushed the 35-map-first-last branch from d1fb2a5 to 6c38e4a Compare June 12, 2023 11:47
@chipshort chipshort merged commit be72bec into release/1.1 Jun 12, 2023
@chipshort chipshort deleted the 35-map-first-last branch June 12, 2023 12:13
@webmaster128 webmaster128 mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add methods to fetch the first or last item in a Map
3 participants
@chipshort @webmaster128 @ueco-jb