cw721-nft-base unit tests #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dace23 to
6fe1b4f
Compare
711aee1 to
3341f7c
Compare
|
Nice start. Thank you for this. Please ping me on discord when you start coding tomorrow, or I will if I start first. If I start first, I would merge this (already a nice step forward) and then start another PR. |
query_all_approvals() (broken) impl
ethanfrey
reviewed
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic unit tests for most of the handlers (will write
approve_all()/revoke_all()tests tomorrow).Tests are not exhaustive, but are a good start. They can be made exhaustive with more time / effort.