Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
Co-authored-by: Mauro Lacy <maurolacy@users.noreply.github.com>
  • Loading branch information
ethanfrey and maurolacy committed Dec 8, 2020
1 parent 9b92138 commit e9a2300
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion contracts/cw3-flex-multisig/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ to modify it's own group, do the following in multiple transactions:

* init cw4-group, with your personal key as admin
* init a multisig pointing to the group
* `AddHook{multisig}` on the group contract
* `AddHook{multisig}` on the group contract
* `UpdateAdmin{multisig}` on the group contract

This is the current practice to create such circular dependencies,
Expand Down
3 changes: 2 additions & 1 deletion contracts/cw3-flex-multisig/src/contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -698,11 +698,12 @@ mod tests {
);

let proposal = pay_somebody_proposal(&flex_addr);
// Only voters can propose
let res = app.execute_contract(SOMEBODY, &flex_addr, &proposal, &[]);
assert_eq!(res.unwrap_err(), ContractError::Unauthorized {}.to_string());

// Wrong expiration option fails
let msgs = match pay_somebody_proposal(&flex_addr) {
let msgs = match proposal.clone() {
HandleMsg::Propose { msgs, .. } => msgs,
_ => panic!("Wrong variant"),
};
Expand Down

0 comments on commit e9a2300

Please sign in to comment.