Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IbcAckCallbackMsg and IbcTimeoutCallbackMsg fields public #2191

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Make IbcAckCallbackMsg and IbcTimeoutCallbackMsg fields public #2191

merged 2 commits into from
Jul 20, 2024

Conversation

chipshort
Copy link
Collaborator

These should be public, otherwise you cannot read them in the contract.

@chipshort chipshort requested a review from webmaster128 July 18, 2024 13:33
webmaster128
webmaster128 reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice fix. We need a CHANGELOG entry for this I think

@webmaster128 webmaster128 merged commit cc0d19b into main Jul 20, 2024
31 checks passed
@webmaster128 webmaster128 deleted the co/make-fields-pub branch July 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chipshort @webmaster128