Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IntoIterator for DistributionQuerier::new parameter #1941

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Use IntoIterator for DistributionQuerier::new parameter #1941

merged 4 commits into from
Nov 8, 2023

Conversation

chipshort
Copy link
Collaborator

closes #1792

webmaster128
webmaster128 reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. But looking at the original conversation, I think the motivation was to be able to use this without HashMap. Could you also change the field to BTreeMap like the others and add a test with two or three different input types?

webmaster128
webmaster128 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

@chipshort chipshort merged commit ab9dff9 into main Nov 8, 2023
@chipshort chipshort deleted the 1792-avoid-hashmap branch November 8, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use IntoIterator in DistributionQuerier::new
2 participants
@chipshort @webmaster128