-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distribution module query type #1593
Add distribution module query type #1593
Conversation
917b105
to
dda6d7b
Compare
Let's schedule this for 1.3 after #1647 is in. Then you have the relevant feature flag in place for the additional query. |
dda6d7b
to
6873497
Compare
I rebased this on 1.3 and added a way to mock it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Just the feature thing and then it would be good to add a note to both
- CHANGELOG.md
- docs/CAPABILITIES-BUILT-IN.md
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
This adds a query type for the distribution module. I've linked to the cosmos-sdk protobufs where relevant, though I'd appreciate advice on how best to test this.
Related PR to add
SetWithdrawAddress
to multi-test: CosmWasm/cw-multi-test#23