Add separate constructor for IbcReceiveResponse

CosmWasm · Dec 13, 2023 · 45acc95 · 45acc95
1 parent e88ee72
commit 45acc95
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 16 deletions.
diff --git a/packages/std/src/ibc.rs b/packages/std/src/ibc.rs
@@ -638,7 +638,20 @@ impl<T> IbcReceiveResponse<T> {
     /// ```
     pub fn new(ack: impl Into<Binary>) -> Self {
         Self {
-            acknowledgement: ack.into(),
+            acknowledgement: Some(ack.into()),
+            messages: vec![],
+            attributes: vec![],
+            events: vec![],
+        }
+    }
+
+    /// Creates a new response without an acknowledgement.
+    ///
+    /// This allows you to send the acknowledgement asynchronously later using [`IbcMsg::WriteAcknowledgement`].
+    /// If you want to send the acknowledgement immediately, use [`IbcReceiveResponse::new`].
+    pub fn without_ack() -> Self {
+        Self {
+            acknowledgement: None,
             messages: vec![],
             attributes: vec![],
             events: vec![],

diff --git a/packages/std/src/stdack.rs b/packages/std/src/stdack.rs
@@ -118,12 +118,6 @@ impl From<StdAck> for Binary {
     }
 }
 
-impl From<StdAck> for Option<Binary> {
-    fn from(original: StdAck) -> Option<Binary> {
-        Some(original.into())
-    }
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -166,13 +160,4 @@ mod tests {
         let ack2 = StdAck::error("kaputt");
         assert_eq!(ack2.to_binary(), br#"{"error":"kaputt"}"#);
     }
-
-    #[test]
-    fn stdack_to_option_binary_works() {
-        let ack1 = StdAck::success(b"\x01");
-        assert_eq!(Option::<Binary>::from(ack1.clone()), Some(ack1.to_binary()));
-
-        let ack2 = StdAck::error("kaputt");
-        assert_eq!(Option::<Binary>::from(ack2.clone()), Some(ack2.to_binary()));
-    }
 }