PruneUserJob realm bug

[GunniBusch]

Current Behavior

If proxmox has users in different realms as specified in

panel/app/Enums/Node/Access/RealmType.php

Lines 5 to 9 in bdc9c41

	enum RealmType: string
	{
	case PAM = 'pam';
	case PVE = 'pve';
	}

PruneUserJob will fail.
The reason is, that convoy gets all users, and converts them into UserData. UserData, casts the realm into said enum.
Consequently there will be an error, before a deletion can occur. See here:

panel/app/Repositories/Proxmox/Node/ProxmoxAccessRepository.php

Line 24 in bdc9c41

$users = array_map(fn ($user) => UserData::fromRaw($user), $this->getData($response));

To fix this, I would suggest when getting users, first to check if the realm can be casted, and only then creating a Data Object.

Expected Behavior

As pointed out earlier, to ignore users with realm type different than in the enum

Steps to Reproduce

Create a user with a realm eg. openid and run the job PruneUserJob

Screenshots

No response

Proxmox OS Version

/

Operating System

/

Browser

/

Additional Context

No response

Panel Version

4.2.4

Error Logs

No response

Is there an existing issue for this?

• I have searched the existing issues before opening this issue.
• I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.

[ericwang401]

Hello, thanks for your report! When is realm type not defined as pam or pve?

[GunniBusch]

Hello, thanks for your report! When is realm type not defined as pam or pve?

For example if someone uses openid.

https://pve.proxmox.com/wiki/User_Management#pveum_authentication_realms

But I see that the realm types are fixed. So you can add the missing ones to the enum:

ad | ldap | openid | pam | pve

I can update the pr