Choice button: Use proper enum index even if options differ from VEnum #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow choice buttons with custom options A, C, E for PVs with enum labels A, B, C, D, E
#2629
Without "Items from PV" selected, the PV's value may not match any of the custom choice button options.
Indicate with same border as "disconnected". This may be an overload of the border meaning, but avoids having to invent another way to indicate the issue. The border is quite obvious in indicating a problem, the tool tip will show the current value and help explain why no button option is selected, and in a way the value of the PV is disconnected from the available choices.