-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services-alarm-server : increase STABILIZATION_SECS when exporting #2596 #2597
services-alarm-server : increase STABILIZATION_SECS when exporting #2596 #2597
Conversation
…ontrolSystemStudio#2596 added new argument export_wait
That number "4" was somewhat arbitrary, so it's a good idea to make it configurable. Still, I wonder if we should change the default, or if there's something else going on with your setup. The fundamental issue is that the configuration is a stream. There's no way to know if we now have received the "complete" configuration, because it's never complete, an item can be added/removed/updated and then you get another configuration message. |
Those are the idle "state:".. updates which are indeed happening every 10 seconds, or of course whenever there's a state change. The When you run
|
If you run |
Well, that's interesting. For me, it takes about 1 second to startup/connect/get the first value. Is there something in your network setup or kafka configuration that would explain a longer initial delay? So in your case it looks like it's mostly about that initial connection time. Also, the problem might be more generally handled by waiting for the first config message, and only then enabling the (by default) 4 second stabilization check, because I assume you also get all the config messages in rapid succession once the client is properly connected. |
I'll create an update that adds an initial wait for the first config message, which is basically a connection timeout, changes the parameter name from "-export_wait" because it's actually also used for "-import", and lists that parameter in the "-help" output. |
Thanks for the merge. |
OK, there's now a designated This applies to import, export as well as alarm server startup |
Note the change in names. Instead of |
I did some tests on another server and I only needed 1s for connect_secs instead of 10 on my computer, so the problem was more my computer. |
Thanks for the update! It's certainly good that we now have a configurable delay for the initial connection, because no matter if it's 1 or 10 seconds, getting that initial message always seems to take longer. From then on, we can usually receive 1000 or more per second. |
Added an argument export_wait to change the STABILIZATION_SECS default value of 4s.
My server is slow and 4s is too small to get a correct export.
Also added the possibility to set it in the settings.ini (org.phoebus.applications.alarm/export_wait)
Not sure the name I've chosen is the best, let you change it if necessary.