Provide visual feed-back if alarm actions fail #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's also https://github.com/ornl-epics/alarm-webmon for offering a read-only view of current alarms, but it's really just that. To open related displays etc. the desktop version is necessary, and displaying errors is certainly good. It's just look at the |
|
OK, I'll update. |
kasemir
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A site may configure the Kafka alarm service to allow producer messages only from certain IP addresses. This can be useful if alarm information is of interest to a wide audience, but actions should be allowed only from a limited context.
As this the current setup at ESS we discovered that blocked producer messages failed as expected, but left the user confused as nothing changed in the UI. This PR adds some code to display an error dialog in such cases.