CSSTUDIO-1761 (Part 2/2) Functionality to save the layout of an individual window #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from "Application" to "PhoebusApplication".
…ebusApplication".
…m the constructors of "DeleteLayoutsMenuItem" and "SaveLayoutMenuItem" by using "PhoebusApplication.INSTANCE" instead.
…eLayoutMenuItem".
…saveLayout() and make saveLayout() "public". Add call to save_layout.setOnAction() in "PhoebusApplication". Remove the helper function MementoHelper.saveStages().
… the menu that appears when one right-clicks on a tab.
…ages to be saved. This prevents an unrelated window from being focused when saving the layout using "Save Layout of Containing Window".
…per", remove the inheritance of "SaveLayoutHelper" from the class "MenuItem", and make all the methods of "SaveLayoutHelper" "static".
…item to the bottom of the menu that appears when one right-clicks on a tab.
kasemir
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSSTUDIO-1761asks for implementation of:This merge-request implements point 1. Merge-request #2550 implements point 2.
The implemented save-functionality is accessed through the added menu item "Save Layout of Containing Window As..." in the context menu that appears when one right-clicks on a tab.
In order to enable code-sharing between the implemented functionality and the existing functionality to save a complete layout ("Window" -> "Save Layout As..."), the class
SaveLayoutMenuItemwas renamed toSaveLayoutHelper, its methods were turned intostaticmethods, and its inheritance fromMenuitemwas removed.