Databrowser: Fix deleting traces with annotation. #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whhen deleting a trace with annotation, the annotation remained orphaned. It was on the screen, but would no longer snap to any trace. It would be saved in the *.plt file with -1 as the item index, and when later loading the file, there'd be an error dialog. This fixed the main issue by removing the annotation when deleting the trace. Note that there's no complete "undo": Undo will restore the trace, but for now not recover the annotation for the trace. That would be another thing to implement as time permits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a trace with annotation, the annotation remained orphaned. It was on the screen, but would no longer snap to any trace. It would be saved in the *.plt file with -1 as the item index, and when later loading the file, there's an error dialog because of the invalid array index.
This fixed the main issue by removing the annotation when deleting the trace.
Note that there's no complete "undo": Undo will restore the trace, but for now not recover the annotation for the trace. That would be another thing to implement as time permits.