Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display enum Labels in Databrowser #2488

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

thomas1028
Copy link

Now Displays Labels for the VEnum data type in the Data Browser.
Also now determines display only for the first Data point and stores that for following data points to use
Screenshot_20221216_143735
original label
Screenshot_20221216_144422
new label

@kasemir
Copy link
Collaborator

kasemir commented Dec 16, 2022

Great idea!
In all the other displays like Display Builder, Probe, PV Tree, .., however, we generally prefer to show the label instead of the number. So maybe the marker should also be "Normal (5.00)" instead of "5.00 (Normal)" to again emphasize that this is a labelled entity where the label is the primary representation, the the number is just used out of necessity to allow plotting it.

@kasemir
Copy link
Collaborator

kasemir commented Dec 16, 2022

Actually, "Normal (5)" would be ideal: Show the label first, then the enum index, and we know that the index is always an integer, so no need to add decimals.

@shroffk shroffk merged commit 4f847ed into ControlSystemStudio:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants