Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alarm logging service #2409

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Alarm logging service #2409

merged 3 commits into from
Oct 11, 2022

Conversation

shroffk
Copy link
Member

@shroffk shroffk commented Oct 6, 2022

cleaning up the alarm server elastic queries

TODO:
how the search query string and parameters are handled can be simplified... for the time being I am just adding the root key word and making the minimum changes needed to get the root search support working

@shroffk shroffk requested review from georgweiss and tanviash October 7, 2022 12:45
Copy link
Collaborator

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

root=* is not added to the default search string in the alarm log table text field. If I add it, it is removed when query is invoked.

@shroffk
Copy link
Member Author

shroffk commented Oct 11, 2022

the root search key word is re-ordered based on the enum order so it might move to the second position
image

I have added it to the default search string... but I intend to just redo this by the developers meeting.

@georgweiss
Copy link
Collaborator

Sorry, my bad.

@georgweiss georgweiss self-requested a review October 11, 2022 13:59
@shroffk
Copy link
Member Author

shroffk commented Oct 11, 2022

no worries at all... as I said we will clean this up soon.

@shroffk shroffk merged commit ac37778 into master Oct 11, 2022
@shroffk shroffk deleted the alarm_logging_service branch September 11, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants