Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -v option to log inspected jars, detected properties files #2391

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

kasemir
Copy link
Collaborator

@kasemir kasemir commented Sep 16, 2022

... and packages.
Since tool from #2390 may run for 30 seconds, this option provides feedback on the progress of parsing the files.

@tynanford
Copy link
Contributor

I like this update. While the PR is open, can you add a check for len(jar_file_list) == 0 and print a message that no jar files are found? I thought that could be a hint that a build is needed first

@kasemir kasemir merged commit d163aa4 into master Sep 16, 2022
@kasemir kasemir deleted the sett_tmpl_tool_verbose branch September 16, 2022 15:46
@kasemir
Copy link
Collaborator Author

kasemir commented Sep 16, 2022

Since it's Friday..
I noticed that you're using type hints (product_location: str, ...) -> None.
Do they actually do anything, or is python support for type hints still mostly for documentation?
Are you using an editor where you get warnings when you pass parameters of the wrong type?

@tynanford
Copy link
Contributor

Thanks for adding that.

Yeah they still don't do anything. I started to use them about a year ago mostly for documentation and a little hint to others... and because I personally think it would be nice if they were more standard. They can be nice if you use Pycharm too.

But it looks like the python devs specifically have said they won't ever mandate type hints: https://peps.python.org/pep-0484/#non-goals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants