Csstudio 1338: ScaledSlider and Scrollbar Widgets Reflect Incorrect PV Value When Dragged Outside Limits

[cjenkscybercom]

Fixes #2376

[cjenkscybercom]

Something really strange going on here with the commits...taking a look

[kasemir]

The commits appear to be the ones about the font fixes that have already been applied..

[cjenkscybercom]

Hmm, I'm going to try pulling this all fresh, there's some changes that git diff should pick up on that aren't being picked up--never had this happen before! Either way, I still want to apply this work to the scrollbar widget as well anyway.

[cjenkscybercom]

Alright @kasemir this should be good to go.
Just a last check -- and this is more for my JavaFX experience -- I don't believe we need to somehow unregister the setOnMouseRelease call, unlike the others where we are adding the listeners directly?

[kasemir]

I don't believe we need to somehow unregister the setOnMouseRelease call

I think that's correct. The JFX listeners don't need to be removed because the complete JFX scene graph gets disposed when we remove the representation.
For the listeners to our model we do remove the property listeners because otherwise we had memory leaks, or would call the listeners in the representation when the GUI was gone but the model still there.... but I can't right now point out exactly how that happened, because when you for example close a display then the model that was represented gets disposed, which should include the listeners.

[kasemir]

This is where we added the listener removal: kasemir/org.csstudio.display.builder#479

[kasemir]

.. scrollbar widget as well ..

Excellent, thanks!