Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTUDIO-1131: tab/shift-tab navigation between elements/nodes in widget color property popover #2382

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

cjenkscybercom
Copy link
Contributor

@cjenkscybercom cjenkscybercom commented Sep 14, 2022

This feature enables tab/shift-tab navigation in color property popovers in the Display Editor.
The below image illustrates this, the exception being there is navigation between the search text field and Red spinner to the Color colorpicker field.
Screenshot 2022-09-13 at 10 40 30

Copy link
Collaborator

@kasemir kasemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Does this then require #2383, without the TAB support #2383 was fine?

@cjenkscybercom
Copy link
Contributor Author

cjenkscybercom commented Sep 14, 2022

Looks good. Does this then require #2383, without the TAB support #2383 was fine?

It doesn't require those changes. Since the fix ended up being a one-liner I verified on the other branch and the changes are independent from each other from what I could observe.

@cjenkscybercom
Copy link
Contributor Author

Gonna fix these conflicts from the other merges in just a sec...

@kasemir
Copy link
Collaborator

kasemir commented Sep 14, 2022

the changes are independent from each other

.. git begs to differ ;-)

@cjenkscybercom
Copy link
Contributor Author

cjenkscybercom commented Sep 14, 2022

the changes are independent from each other

.. git begs to differ ;-)

hah ;)
I meant functionally, doh, wasn't clear on that

@kasemir
Copy link
Collaborator

kasemir commented Sep 14, 2022

Right. Mean what you say and say what is mean!
Wait, that doesn't sound right?!

@kasemir kasemir merged commit 0cf353d into master Sep 14, 2022
@kasemir kasemir deleted the CSSTUDIO-1131 branch September 14, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants