Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value of DESC (if non-null and non-empty) to pv_value in widget tooltip #2354

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

georgweiss
Copy link
Collaborator

If PV defines the DESC field, and if it is non-empty, it's value will be shown in the widget tooltip. Implementation proposes to put the string on a separate line:

Screenshot 2022-08-12 at 15 26 12

NOTE: works only over pva.

The value of DESC is read from the recently added description field of the Display class in the VType lib.

@georgweiss georgweiss requested review from kasemir and shroffk August 12, 2022 13:34
Copy link
Collaborator

@kasemir kasemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

You always add the description to the $(pv_value).
In hindsight, we could have supported something like $(pv_time), $(pv_value), $(pv_alarm), $(pv_description), $(pv_units), ... which would allow configuring tool tips to show just the value, or value with units etc.

But that would mean people who want to now see the description need to update all their tooltips to add $(pv_description), which is not practical.
Besides, this is just the tool tip, where having the choice between a default that shows PV name and value vs. some custom text is probably good enough.
No need for detailed configuration of how time, value, alarm, desc. are formatted.

@kasemir kasemir merged commit 1dd1009 into master Aug 12, 2022
@kasemir kasemir deleted the CSSTUDIO-1265 branch August 12, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants