Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: text alignment in Spinner widget #2339

Merged
merged 1 commit into from
Jul 29, 2022
Merged

feature: text alignment in Spinner widget #2339

merged 1 commit into from
Jul 29, 2022

Conversation

cjenkscybercom
Copy link
Contributor

No description provided.

@cjenkscybercom
Copy link
Contributor Author

cjenkscybercom commented Jul 28, 2022

I've verified this by checking alignment updates in real time in the editor, and that the changes are persisted when the widget is viewed in the Viewer. I'm not sure, however, if I can test this with a real PV or not without write permissions? I'm not super familiar with this widget, so any tips would be appreciated; I could try to create a db file to test this with.

@kasemir
Copy link
Collaborator

kasemir commented Jul 28, 2022

Can you try with sim://ramp to check if it displays received updates from a read-only PV?
Then try with the PV loc://x(0) in both a spinner and a text entry widget.
Should be able to change the PV from a spinner.
Then also change it via the text entry and check if the spinner updates as expected.

@cjenkscybercom
Copy link
Contributor Author

Can you try with sim://ramp to check if it displays received updates from a read-only PV? Then try with the PV loc://x(0) in both a spinner and a text entry widget. Should be able to change the PV from a spinner. Then also change it via the text entry and check if the spinner updates as expected.

Thank you! I'll try to remember those.
Checking it, the value updates in real time (and is read-only), and I can increment/decrement the loc value -- so I think it looks good!

@kasemir kasemir merged commit c101e59 into master Jul 29, 2022
@kasemir kasemir deleted the CSSTUDIO-1724 branch July 29, 2022 12:42
@kasemir
Copy link
Collaborator

kasemir commented Jul 29, 2022

Thanks for checking with those PVs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants