Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alarm logger: First check parameters, incl. help, then start app #2314

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

kasemir
Copy link
Collaborator

@kasemir kasemir commented Jun 27, 2022

Fixes part of #2277 where calling alarm logger with -help just to see parameters will result in trying to start tomcat, connect to ports etc., and error messages then clobber the -help that one wanted to see

@kasemir kasemir requested a review from shroffk June 27, 2022 17:17
@shroffk
Copy link
Member

shroffk commented Jun 27, 2022

This makes sense.
Currently, I have a lot of changes on the elastic8 branch.... I am hoping that at next weeks monthly meeting I can get the green light for all sites and merge that into master. I will cherry pick these changes onto that branch too and hope it does not cause conflicts :)

@shroffk shroffk merged commit 5000690 into master Jun 27, 2022
@kasemir kasemir deleted the alarm_logger_help branch June 27, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants