Aligning focus behavior for Spinner widget #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasemir
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Done all testing I can think of, but additional testing would be appreciated.
That never ends with all the possible platforms and future JFX updates, but we can handle issues as they arise.
Looks great for now, just indicating the 'active' state via background color is good progress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus behavior same as for Text Entry widget: when selected explicitly through tab button, the text is selected and overwritten when user enters new value from keyboard or by using up/down button.
Also fixed ESCAPE handling which did not work. Apparently JavaFX Spinner will not receive key event from ESCAPE button using onKeyPressed, need to use event filter instead.
ESCAPE reverts back to unedited value.
Done all testing I can think of, but additional testing would be appreciated.