Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli option to specify Hikari configuration for pruning db connection #663

Merged
merged 4 commits into from
Oct 31, 2022
Merged

Cli option to specify Hikari configuration for pruning db connection #663

merged 4 commits into from
Oct 31, 2022

Conversation

usmansaleem
Copy link
Collaborator

PR Description

Cli option to specify Hikari configuration for pruning

Fixed Issue(s)

Fixes #661

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@usmansaleem usmansaleem self-assigned this Oct 27, 2022
@usmansaleem usmansaleem added the doc-change-required Indicates an issue or PR that requires doc to be updated label Oct 27, 2022
jframe
jframe approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitignore
@@ -28,3 +28,4 @@ out/
docker/reports/*
.vscode
.lh/*
.fleet/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intellij Fleet IDE cache folder.

@usmansaleem usmansaleem merged commit 99f048b into Consensys:master Oct 31, 2022
@usmansaleem usmansaleem deleted the hikari_pruning_conf branch October 31, 2022 05:45
@alexandratran alexandratran mentioned this pull request Nov 8, 2022
Closed
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees

@usmansaleem usmansaleem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to specify Hikari configuration file for pruning connection
3 participants
@usmansaleem @jframe @alexandratran