Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the community membership & contributing docs #634

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Clean up the community membership & contributing docs #634

merged 3 commits into from
Sep 5, 2022

Conversation

jtraglia
Copy link
Contributor

PR Description

  • Remove reference to nonexistent /community/code-reviews.md document.
  • Remove duplicate "Pull Request Labels" header.
  • Remove ToC entry for "Git Commit Messages & Pull Request Messages" section.
  • Rename "Code Review" section to "Code Reviews" (plural) to match table of contents.
  • Use correct numbers for list (I know it renders as the same).
  • Format membership responsibilities table.
  • For ONLY the community membership document, line wrap to 80 characters.
    • I noticed that some paragraphs were wrapped and some weren't.
    • Went with 80 instead of 120 because that's what other paragraphs were at.
  • To maintain consistency, add blank line between header and paragraphs in some places.
  • To maintain consistency, remove periods from list entries.
  • To maintain consistency, use only one space between new sentences.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor thing

Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siladu siladu merged commit 19917f2 into Consensys:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants