Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use localstack for AWS testing #1067

Merged
merged 15 commits into from
Mar 5, 2025

Conversation

usmansaleem
Copy link
Collaborator

PR Description

Use localstack for AWS testing

Fixed Issue(s)

fixes #1066

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@@ -9,6 +9,10 @@ on:
schedule:
- cron: '39 22 * * 5'

concurrency:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cancels the previous run of codeql if a new commit is pushed.

@usmansaleem usmansaleem merged commit 70ad630 into Consensys:master Mar 5, 2025
8 checks passed
@usmansaleem usmansaleem deleted the localstack_aws branch March 5, 2025 04:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use localstack in CI for AWS secrets manager/kms Acceptance tests
2 participants