Skip to content

Commit

Permalink
code fix
Browse files Browse the repository at this point in the history
  • Loading branch information
usmansaleem committed Feb 26, 2025
1 parent 1265ea5 commit e4736ed
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import static tech.pegasys.web3signer.dsl.utils.HealthCheckResultUtil.getHealtcheckKeysLoaded;
import static tech.pegasys.web3signer.dsl.utils.HealthCheckResultUtil.getHealthcheckErrorCount;

import org.apache.commons.lang3.StringUtils;
import tech.pegasys.web3signer.dsl.signer.SignerConfigurationBuilder;
import tech.pegasys.web3signer.signing.KeyType;
import tech.pegasys.web3signer.signing.config.AzureKeyVaultParameters;
Expand All @@ -34,7 +33,7 @@
import com.fasterxml.jackson.core.JsonProcessingException;
import io.restassured.http.ContentType;
import io.restassured.response.Response;
import org.junit.jupiter.api.Assumptions;
import org.apache.commons.lang3.StringUtils;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import static org.junit.jupiter.api.Assumptions.assumeTrue;
import static tech.pegasys.web3signer.keystorage.azure.AzureKeyVault.createUsingClientSecretCredentials;

import org.apache.commons.lang3.StringUtils;
import tech.pegasys.web3signer.keystorage.common.MappedResults;

import java.util.AbstractMap.SimpleEntry;
Expand All @@ -28,8 +27,8 @@
import java.util.concurrent.Executors;

import com.azure.security.keyvault.keys.models.KeyProperties;
import org.apache.commons.lang3.StringUtils;
import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Assumptions;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
import static org.junit.jupiter.api.Assumptions.assumeTrue;
import static tech.pegasys.web3signer.signing.secp256k1.azure.AzureKeyVaultSignerFactory.UNSUPPORTED_CURVE_NAME;

import org.apache.commons.lang3.StringUtils;
import tech.pegasys.web3signer.signing.config.AzureKeyVaultFactory;
import tech.pegasys.web3signer.signing.secp256k1.EthPublicKeyUtils;
import tech.pegasys.web3signer.signing.secp256k1.Signature;
Expand All @@ -27,8 +26,8 @@
import java.math.BigInteger;
import java.security.SignatureException;

import org.apache.commons.lang3.StringUtils;
import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Assumptions;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.web3j.crypto.Sign;
Expand All @@ -49,7 +48,8 @@ public class AzureKeyVaultSignerTest {

@BeforeAll
static void preChecks() {
assumeTrue(!StringUtils.isEmpty(AZURE_CLIENT_ID)
assumeTrue(
!StringUtils.isEmpty(AZURE_CLIENT_ID)
&& !StringUtils.isEmpty(AZURE_CLIENT_SECRET)
&& !StringUtils.isEmpty(AZURE_KEY_VAULT_NAME)
&& !StringUtils.isEmpty(AZURE_INVALID_KEY_VAULT_NAME)
Expand Down

0 comments on commit e4736ed

Please sign in to comment.