Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wrapper validation #9151

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Update wrapper validation #9151

merged 2 commits into from
Feb 20, 2025

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Feb 20, 2025 •
edited
Loading

it is failing quite a bit, hopefully v4 will better handle timeouts

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

mehdi-aouadi
mehdi-aouadi approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr enabled auto-merge (squash) February 20, 2025 10:47
@tbenr tbenr merged commit 82152d1 into master Feb 20, 2025
18 checks passed
@tbenr tbenr deleted the update-wrapper-validation branch February 20, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehdi-aouadi mehdi-aouadi mehdi-aouadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @mehdi-aouadi