PART 1 - GET/Attestation Pool API - Handle Electra attestations in the aggregating pool

[mehdi-aouadi]

PR Description

In preparation for the GET attestation from the aggregating attestation pool API.
Handle the Electra attestations when querying attestations from the aggregation pool

Fixed Issue(s)

#8029

Documentation

• I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

• I thought about adding a changelog entry, and added one if I deemed necessary.

[greptile-apps]

PR Summary

• Added handling for Electra attestations in ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/attestation/AggregatingAttestationPool.java
• Introduced logic to filter attestations requiring committee bits
• Ensured correct schema definitions based on slot
• Added test cases for Electra attestations in ethereum/statetransition/src/test/java/tech/pegasys/teku/statetransition/attestation/AggregatingAttestationPoolTest.java
• Refactored methods and added mock behaviors for different spec milestones

_{2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Synchronized getSchemaDefinitions method in ethereum/statetransition/src/main/java/tech/pegasys/teku/statetransition/attestation/AggregatingAttestationPool.java
• Ensured thread safety for handling Electra attestations
• No major changes found since last review

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Added AttestationElectra class for handling Electra attestations
• Implemented AttestationElectraSchema for Electra attestation structure
• Included committeeBits field in AttestationElectra
• Ensured committeeBits are required for Electra attestations
• Updated create methods to handle Electra-specific attestation creation

_{No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Removed limit on attestations returned from getAttestations in AggregatingAttestationPool
• Added filtering for attestations requiring committee bits
• Potential increase in number of attestations returned by getAttestations

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[tbenr]

LGTM

[greptile-apps]

PR Summary

(updates since last review)

• Refactored waitForNonDefaultExecutionPayload in acceptance-tests/src/testFixtures/java/tech/pegasys/teku/test/acceptance/dsl/TekuBeaconNode.java for readability.
• Updated getter methods in beacon/validator/src/main/java/tech/pegasys/teku/validator/coordinator/ValidatorApiHandler.java for SyncCommitteeSubnetSubscription.
• Introduced PostSyncCommitteeData and SyncCommitteeSubnetSubscription classes in ethereum/json-types/src/main/java/tech/pegasys/teku/ethereum/json/types/validator.
• Added IPv6 support in networking/p2p/src/main/java/tech/pegasys/teku/networking/p2p/discovery/discv5/DiscV5Service.java.
• Updated state pruning configurations in storage/src/main/java/tech/pegasys/teku/storage/server/StorageConfiguration.java.

_{32 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Updated getAttestations_shouldReturnElectraAttestationsOnly_whenElectraActivatesAndNoSlotProvided method name and comments in ethereum/statetransition/src/test/java/tech/pegasys/teku/statetransition/attestation/AggregatingAttestationPoolTest.java
• Ensure test cases reflect handling of Electra attestations in the aggregation pool

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}