Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GetDepositSnapshot to beacon APIs package #8136

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Move GetDepositSnapshot to beacon APIs package #8136

merged 2 commits into from
Mar 25, 2024

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Mar 24, 2024

…ready)

PR Description

It's a part of official API already with eth/beacon url and BEACON tag

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

StefanBratanov
StefanBratanov approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zilm13 zilm13 merged commit 1cdc8d0 into Consensys:master Mar 25, 2024
16 checks passed
@zilm13 zilm13 deleted the deposit-snapshot-api branch March 25, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zilm13 @StefanBratanov