Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chrome rendering #10

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix Chrome rendering #10

merged 1 commit into from
Feb 15, 2023

Conversation

rcstanciu
Copy link
Contributor

The report rendering is triggered by a window message, which happens immediately in the <head> section. Because the DOM is not fully loaded, the div#preview element is not yet loaded, resulting in document.getElementById("preview") returning null.

This change defers posting the message and triggering the report rendering until the document has been fully loaded, fixing the issue where the report was not rendering on Chrome.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2023

CLA assistant check
All committers have signed the CLA.

@tintinweb tintinweb merged commit b19dec1 into Consensys:master Feb 15, 2023
@tintinweb
Copy link
Member

excellent, thank you @rcstanciu 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants