[Upgrade] Go-Ethereum release v1.9.21 #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(#21334) * accounts/abi/bind/backends: Disallow timeshift for non-empty blocks * accounts/abi/bind/backends: added tests for adjust time * accounts/abi/bind/simulated: added comments, fixed test for AdjustTime * accounts/abi/bind/backends: updated comment
* go.mod | goleveldb latest update * go.mod update * leveldb options * go.mod: double check Co-authored-by: Péter Szilágyi <peterke@gmail.com>
core/state, eth, trie: stabilize memory use, fix memory leak
… calls (#21387) * tests: add testdata of call tracer * eth/tracers: return revert reason in call_tracer * eth/tracers: regenerate assets * eth/tracers: add error message even if no exec occurrs, fixes #21438 Co-authored-by: Martin Holst Swende <martin@swende.se>
* accounts/abi: fix a bug in getTypeSize method e.g. for "Tuple[2]" type, the element of the array is a tuple type and the size of the tuple may not be 32. * accounts/abi: add unit test of getTypeSize method
* "Downloader queue stats" is now a DEBUG information I think this info is more a DEBUG related information then an INFO. If it must remains an INFO, maybe it can be slow down to one time every 5 minutes or so. * Update queue.go "Downloader queue stats" information is now provided once every minute instead of once every 10 seconds.
This changes how the downloader works, a little bit. Previously, when block sync started, we immediately started filling up to 8192 blocks. Usually this is fine, blocks are small in the early numbers. The threshold then is lowered as we measure the size of the blocks that are filled. However, if the node is shut down and restarts syncing while we're in a heavy segment, that might be bad. This PR introduces a more conservative initial threshold of 2K blocks instead.
core, eth, trie: prepare trie sync for path based operation
* eth: Added TraceTransactionPending * eth: Implement Trace_Call, remove traceTxPending * eth: debug_call -> debug_traceCall, recompute tx environment if pruned * eth: fix nil panic * eth: improve block retrieving logic in tracers * internal/web3ext: add debug_traceCall to console
…nd anonymous variable assignments (#21514) Co-authored-by: Osoro Bironga <osoro@doctaroo.com>
* whisper: remove whisper * Update cmd/geth/config.go Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> * cmd/geth: warn on enabling whisper + remove more whisper deps * mobile: remove all whisper references Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Martin Holst Swende <martin@swende.se>
…ivation paths (#21517) * accounts/usbwallet, signer/core: un-hide accounts from ledger legacy derivation paths * Update accounts/usbwallet/wallet.go * Update signer/core/api.go * Update signer/core/api.go
params: update CHTs for v1.9.21 release
…cts without any signature change
…/go-ethereum/v1.9.21-2021609142421
ricardolyn
approved these changes
Jun 15, 2021
| @@ -44,7 +44,6 @@ require ( | |||
| github.com/golang/mock v1.4.3 | |||
| github.com/golang/protobuf v1.3.4 | |||
There was a problem hiding this comment.
should we add a comment here to maintain the old version?
There was a problem hiding this comment.
do you mean add comment in order to keep the geth's version?
I prefer to prepare another PR to solve the remaining TODOs, which is a revert of the last commit.
There was a problem hiding this comment.
@baptiste-b-pegasys can you create an issue to track this, so we are aware we need to put back the original version from geth?
There was a problem hiding this comment.
in the meantime, I can merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Plan & Analyse
As you review, list extra changes and/or tests to be implemented to ensure compatibility with GoQuorum specific features.
Build & Test
masterinto this branchExtra Changes & Tests
Left TODOs
Go-Ethereum Release: Tavum (v1.9.21)
Release notes
Geth v1.9.21 is a regular maintenance release, the highlights being the removal of whisper, better call tracing and multiple memory stability fixes during fast sync to both stabilize usage as well as to fix a memory leak that lead to crashers before.
debug_traceCallon top of arbitrary blocks (#21338).call_tracertracer (#21387).snapsync (#21504).For a full rundown of the changes please consult the Geth 1.9.21 release milestone
As with all our previous releases, you can find the:
ethereum/client-go.Codebase changes assessment
Legend
File Stats: (A) Added, (M) Modified and (R) Removed
Line Stats: (A) Added and (R) Removed
Assessment:
19 Pull Requests
M/A/R
(files changed)
A/R
(lines changed)
accounts/abi/bind/backends: Disallow AdjustTime for non-empty blocksaccounts/abi/bind/backends(2)accounts/abi/bind/backends/simulated_test.go(82)accounts/abi/bind/backends/simulated.go(16)eth: updated commentseth(3)eth/api.go(4)eth/api_tracer.go(4)eth/bloombits.go(4)go.mod(1)go.sum(1)core/state, eth, trie: stabilize memory use, fix memory leaktrie(4)core/state(2)eth/downloader(1)trie/sync.go(120)eth/downloader/downloader.go(22)core/state/sync.go(12)trie/committer.go(8)core/state/statedb.go(4)eth/tracers: revert reason in call_tracer + error for failed internal callseth/tracers/internal/tracers(2)eth/tracers/testdata(2)eth/tracers(1)eth/tracers/testdata/call_tracer_inner_instafail.json(144)eth/tracers/testdata/call_tracer_revert_reason.json(128)eth/tracers/tracers_test.go(48)eth/tracers/internal/tracers/call_tracer.js(30)eth/tracers/internal/tracers/assets.go(24)rpc: fix issue with null JSON-RPC messagesrpc/testdata(2)rpc(1)rpc/json.go(26)rpc/testdata/invalid-batch.js(6)rpc/testdata/invalid-nonobj.js(6)accounts/abi: fix a bug in getTypeSize methodaccounts/abi(2)accounts/abi/type_test.go(72)accounts/abi/type.go(4)internal: fix personal.sign()console(1)console/bridge.go(8)"Downloader queue stats" is now provided once per minuteeth/downloader(1)eth/downloader/queue.go(4)go.mod: goja updatego.mod(1)go.sum(1)go.sum(8)go.mod(4)eth/downloader: change intial download sizeeth/downloader(5)eth/downloader/downloader_test.go(48)eth/downloader/queue.go(28)eth/downloader/queue_test.go(12)eth/downloader/downloader.go(8)eth/downloader/testchain_test.go(4)core, eth, trie: prepare trie sync for path based operationtrie(4)core/state(1)eth/downloader(1)eth/downloader/statesync.go(306)trie/sync_test.go(298)core/state/sync_test.go(254)trie/trie.go(168)trie/sync.go(132)eth: added trace_call to trace on top of arbitrary blockseth(2)internal/web3ext(1)eth/api_tracer.go(98)eth/api.go(14)internal/web3ext/web3ext.go(12)accounts/abi/bid/backends:accounts/abi/bind/backends(2)accounts/abi/bind/backends/simulated.go(264)accounts/abi/bind/backends/simulated_test.go(40)whisper: remove whisperwhisper/whisperv6(17)mobile(3)cmd/geth(3)whisper/mailserver(2)cmd/wnode(1)tests/fuzzers/whisperv6(1)whisper/shhclient(1)cmd/utils(1)tests/fuzzers/whisperv6/corpus(1)whisper/whisperv6/filter_test.go(1672)cmd/wnode/main.go(1546)whisper/whisperv6/api.go(1186)whisper/whisperv6/message_test.go(942)whisper/whisperv6/message.go(710)accounts/usbwallet, signer/core: show accounts from ledger legacy derivation pathsaccounts/usbwallet(1)signer/core(1)signer/core/api.go(66)accounts/usbwallet/wallet.go(28)build: remove wnode from the list of packages binariesbuild(1)build/ci.go(10).github: remove whisper from CODEOWNERS.github(1).github/CODEOWNERS(2)params: update CHTs for v1.9.21 releaseparams(1)params/config.go(64)72 Changed files
whisper/whisperv6/whisper.gowhisper/whisperv6/whisper_test.gowhisper/whisperv6/filter_test.gocmd/wnode/main.gowhisper/whisperv6/api.gowhisper/whisperv6/message_test.gowhisper/whisperv6/message.gowhisper/whisperv6/envelope.gowhisper/whisperv6/peer.gowhisper/whisperv6/filter.gowhisper/mailserver/server_test.gowhisper/mailserver/mailserver.gowhisper/whisperv6/benchmarks_test.gomobile/shhclient.gowhisper/shhclient/client.goeth/downloader/statesync.gotrie/sync_test.goaccounts/abi/bind/backends/simulated.go#21334
whisper/whisperv6/topic_test.gocore/state/sync_test.gotrie/sync.go#21504
mobile/types.gowhisper/whisperv6/doc.gowhisper/whisperv6/envelope_test.gotests/fuzzers/whisperv6/whisper-fuzzer.gowhisper/whisperv6/gen_newmessage_json.gotrie/trie.go#21504
whisper/whisperv6/gen_message_json.goeth/tracers/testdata/call_tracer_inner_instafail.jsonwhisper/whisperv6/gen_criteria_json.gowhisper/whisperv6/api_test.gogo.sum#21448
eth/tracers/testdata/call_tracer_revert_reason.jsonaccounts/abi/bind/backends/simulated_test.go#21334
whisper/whisperv6/topic.goeth/api_tracer.go#21338
accounts/abi/type_test.gosigner/core/api.goparams/config.gowhisper/whisperv6/config.gocmd/utils/flags.gocmd/geth/config.goeth/downloader/downloader_test.goeth/tracers/tracers_test.goeth/downloader/queue.go#21366
eth/downloader/downloader.go#21366
eth/tracers/internal/tracers/call_tracer.jsaccounts/usbwallet/wallet.gogo.mod#21448
rpc/json.goeth/tracers/internal/tracers/assets.gomobile/geth.goeth/api.go#21338
cmd/geth/consolecmd_test.gocore/state/sync.goeth/downloader/queue_test.gotrie/secure_trie.gointernal/web3ext/web3ext.gobuild/ci.gotrie/committer.goconsole/bridge.gorpc/testdata/invalid-nonobj.jsrpc/testdata/invalid-batch.jseth/bloombits.gotrie/trie_test.gocmd/geth/usage.gocore/state/statedb.goaccounts/abi/type.goeth/downloader/testchain_test.goparams/version.go.github/CODEOWNERStests/fuzzers/whisperv6/corpus/009c5adfa4fd685caef58e1ce932fa7fb209730a