Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connecting stitcher-splitter to the compilation suite #562

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Soleimani193
Copy link
Contributor

This PR implements the connection of the stitcher and splitter to the compilation suite.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@Soleimani193 Soleimani193 added the Prover Tag to use for all work impacting the prover label Jan 16, 2025
@Soleimani193 Soleimani193 self-assigned this Jan 16, 2025
Copy link

cla-assistant bot commented Jan 16, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jan 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.46%. Comparing base (fe967c7) to head (1bb8d61).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #562      +/-   ##
============================================
- Coverage     68.81%   68.46%   -0.35%     
+ Complexity     1165     1127      -38     
============================================
  Files           327      321       -6     
  Lines         13030    12822     -208     
  Branches       1311     1283      -28     
============================================
- Hits           8966     8778     -188     
+ Misses         3513     3505       -8     
+ Partials        551      539      -12     
Flag Coverage Δ *Carryforward flag
hardhat 98.74% <ø> (ø)
kotlin 66.01% <ø> (-0.42%) ⬇️ Carriedforward from 9976b8b

*This pull request uses carry forward flags. Click here to find out more.

see 25 files with indirect coverage changes

@Soleimani193 Soleimani193 marked this pull request as ready for review January 16, 2025 10:47
@AlexandreBelling
Copy link
Contributor

@Soleimani193

LGTM, but let's wait to have a clean commit for the upcoming release on main before adding this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants