Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELFDESTRUCT debugging #537

Merged
merged 2 commits into from
Dec 6, 2024
+3 −3
Merged

SELFDESTRUCT debugging #537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e48748
ras: formatting
OlivierBBB Dec 6, 2024
00940be
fix: SUB stamp of reverting SD's
OlivierBBB Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hub/constraints/instruction-handling/halting/selfdestruct.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@

(defconstraint selfdestruct-instruction---returning-empty-return-data (:guard (selfdestruct-instruction---scenario-precondition))
(begin
(if-not-zero (selfdestruct-instruction---STATICX) (execution-provides-empty-return-data 2))
(if-not-zero (selfdestruct-instruction---OOGX) (execution-provides-empty-return-data 4))
(if-not-zero (selfdestruct-instruction---STATICX) (execution-provides-empty-return-data 2))
(if-not-zero (selfdestruct-instruction---OOGX) (execution-provides-empty-return-data 4))
(if-not-zero scenario/SELFDESTRUCT_WILL_REVERT (execution-provides-empty-return-data 6))
(if-not-zero scenario/SELFDESTRUCT_WONT_REVERT_ALREADY_MARKED (execution-provides-empty-return-data 4))
(if-not-zero scenario/SELFDESTRUCT_WONT_REVERT_NOT_YET_MARKED (execution-provides-empty-return-data 5))))
Expand Down Expand Up @@ -324,7 +324,7 @@
(account-undo-code-update ROFF_SELFDESTRUCT___ACCOUNT___2ND_UNDOING_ROW ROFF_SELFDESTRUCT___ACCOUNT___2ND_DOING_ROW)
(account-undo-deployment-status-update ROFF_SELFDESTRUCT___ACCOUNT___2ND_UNDOING_ROW ROFF_SELFDESTRUCT___ACCOUNT___2ND_DOING_ROW)
(account-same-marked-for-selfdestruct ROFF_SELFDESTRUCT___ACCOUNT___2ND_UNDOING_ROW)
(DOM-SUB-stamps---revert-with-current ROFF_SELFDESTRUCT___ACCOUNT___2ND_UNDOING_ROW 2)))
(DOM-SUB-stamps---revert-with-current ROFF_SELFDESTRUCT___ACCOUNT___2ND_UNDOING_ROW 3)))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only real fix


;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; ;;
Expand Down
Loading