Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exo sum must be decoded for LIMB_VANISHES MMIO inst #509

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: exo sum must be decoded for LIMB_VANISHES MMIO inst #509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0507c9f
fix: exo sum must be decoded for LIMB_VANISHES MMIO inst
letypequividelespoubelles Nov 15, 2024
b47a666
Merge branch 'master' into 508-need-to-decode-exosum-for-limb-vanishe…
letypequividelespoubelles Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mmio/constraints.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
(eq! (weighted-exo-sum) (* (instruction-may-provide-exo-sum) EXO_SUM)))

(defun (instruction-may-provide-exo-sum)
(force-bool (+ IS_LIMB_TO_RAM_TRANSPLANT
(force-bool (+ IS_LIMB_VANISHES
IS_LIMB_TO_RAM_TRANSPLANT
Copy link
Collaborator

@OlivierBBB OlivierBBB Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess for zero limbs in MODEXP data ? Either because we are providing < 512 bytes of data for base, exponent or module, or because the call data runs out @letypequividelespoubelles ?

IS_LIMB_TO_RAM_ONE_TARGET
IS_LIMB_TO_RAM_TWO_TARGET
IS_RAM_TO_LIMB_TRANSPLANT
Expand Down
Loading