Adding HUB constraints
#494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
- removed consistency arguemnts - removed internal lookup HUB -> HUB
…urn data (even in the root)
- exceptional version - unexceptional version
fixed storage-instruction---setting-storage-slot-values
- for SSTORE - for SLOAD - undoing row for either
split generalities---setting-CMC-and-XAHOY into 3
the spec only requires the high part to vanish if the instruction is unexceptional (though it doesn't really matter.)
renaming: MULTIPLIER___STACK_HEIGHT -> MULTIPLIER___STACK_STAMP which correctly reflects its purpose
OlivierBBB
commented
Nov 5, 2024
Makefile
Outdated
| @@ -176,7 +176,7 @@ ZKEVM_MODULES_FOR_REFERENCE_TESTS := ${ALU} \ | |||
| ${EUC} \ | |||
| ${EXP} \ | |||
| ${GAS} \ | |||
| ${HUB_COLUMNS} \ | |||
| ${HUB} \ | |||
There was a problem hiding this comment.
This is in ZKEVM_MODULES_FOR_REFERENCE_TESTS, which in any case blows up all over the place.
lorenzogentile404
approved these changes
Nov 5, 2024
letypequividelespoubelles
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.